Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global include Kernel #18093

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Remove global include Kernel #18093

merged 3 commits into from
Aug 20, 2024

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Aug 20, 2024

include Kernel is usually smell from module_function

  • utils/gems: remove module_function
  • reinstall: move to submodule (now Homebrew::Reinstall.reinstall_formulae, which is more consistent with install and upgrade modules)
  • global.rbi: remove

Copy link
Sponsor Member

@dduugg dduugg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff!

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit c2713f8 into master Aug 20, 2024
24 checks passed
@MikeMcQuaid MikeMcQuaid deleted the no-include-kernel branch August 20, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants