Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language/python: avoid modifying all Python symlinks #18128

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Aug 22, 2024

Homebrew Python will always have a realpath in HOMEBREW_CELLAR. Instead, check if the symlink target points to HOMEBREW_CELLAR.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Main goals is to retain valid symlinks like python3 -> #{Formula["[email protected]"].opt_bin}/python3 otherwise the existing logic rewrites to Framework path on macOS which will always differ from Linux.

Still some other differences that need to be fixed up to improve all bottle chance, e.g.

  • lib64 symlink on Linux
  • Realpath executable saved in pyvenv.cfg

Homebrew Python will always have a realpath in HOMEBREW_CELLAR. Instead,
check if the symlink target points to HOMEBREW_CELLAR.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks again @cho-m!

@MikeMcQuaid MikeMcQuaid merged commit d1e0c07 into Homebrew:master Aug 23, 2024
24 checks passed
@cho-m cho-m deleted the python-avoid-modifying-all-links branch August 23, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants