livecheck: remove module_function
#18130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
changed the title
module_function
Bo98
force-pushed
the
livecheck-module_function
branch
2 times, most recently
from
b536ee6
to
2f76a38
Compare
Bo98
force-pushed
the
livecheck-module_function
branch
from
2f76a38
to
f877fc5
Compare
carlocab
approved these changes
Aug 23, 2024
MikeMcQuaid
approved these changes
Aug 23, 2024
|
Thanks again @Bo98! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives stronger typing and fixes an issue causing type signatures to not apply properly in some cases.
Also make internal helper methods private where possible. I left the ones that have attached rspec tests, even if they're only actually meant for internal use.