Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/github: fix too_many_open_prs? #18150

Merged
merged 2 commits into from
Aug 24, 2024
Merged

utils/github: fix too_many_open_prs? #18150

merged 2 commits into from
Aug 24, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This doesn't count PRs from forks, so it only works correctly for
maintainers (and only if they use non-fork branches).

Let's fix that, and:

  • simplify the logic by using paginate_graphql
  • return early if it's impossible for them to have too many open PRs

This doesn't count PRs from forks, so it only works correctly for
maintainers (and only if they use non-fork branches).

Let's fix that, and:
- simplify the logic by using `paginate_graphql`
- return early if it's impossible for them to have too many open PRs
Co-authored-by: Markus Reiter <[email protected]>
@Bo98 Bo98 merged commit a208b1b into master Aug 24, 2024
24 checks passed
@Bo98 Bo98 deleted the pr-count-fix branch August 24, 2024 19:16
carlocab added a commit that referenced this pull request Aug 24, 2024
@MikeMcQuaid
Copy link
Member

Makes sense, thanks @carlocab!

ctaintor pushed a commit to ctaintor/brew that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants