Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/shared_audits: allow subgroups in gitlab url #18174

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Aug 27, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

To fix: https:/Homebrew/homebrew-core/actions/runs/10570029877/job/29283904401#step:3:38

Subgroups: https://docs.gitlab.com/ee/user/group/subgroups/

Extra characters: https://docs.gitlab.com/ee/user/reserved_names.html#limitations-on-usernames-project-and-group-names-and-slugs


The starting \w is a slightly shorter-to-type superset of [A-Za-z0-9] (#{Alnum}). Mainly to avoid [\w.-]+ matching unique /-/; however, not really needed as there should never be a URL with /-/-/

@MikeMcQuaid MikeMcQuaid merged commit 83645e2 into master Aug 27, 2024
27 checks passed
@MikeMcQuaid MikeMcQuaid deleted the gitlab-urls branch August 27, 2024 08:09
@MikeMcQuaid
Copy link
Member

Thanks again @cho-m!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants