Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linkage_checker: exclude test deps from being considered runtime dep #18281

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Sep 7, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

A couple situations this helps:

  • Avoid no linkage message for test dependencies, e.g. harfbuzz:
    Dependencies with no linkage:
      pygobject3
    
  • Properly detect when a :test-dependency that is also an indirect dep should actually be made a direct runtime dependency.

@carlocab carlocab requested a review from Bo98 September 7, 2024 17:53
@carlocab carlocab merged commit 170a7ea into Homebrew:master Sep 7, 2024
27 checks passed
@cho-m cho-m deleted the linkage_checker-test branch September 7, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants