Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exceptions: skip #fetch_issues is HOMEBREW_NO_BUILD_ERROR_ISSUES is set #18313

Merged
merged 1 commit into from
Sep 12, 2024
Merged

exceptions: skip #fetch_issues is HOMEBREW_NO_BUILD_ERROR_ISSUES is set #18313

merged 1 commit into from
Sep 12, 2024

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This will allow us to set HOMEBREW_NO_BUILD_ERROR_ISSUES in our
workflows, which will avoid needlessly burning through our rate limit.

@carlocab
exceptions: skip #fetch_issues is HOMEBREW_NO_BUILD_ERROR_ISSUES …
a4b4338 
…is set

This will allow us to set `HOMEBREW_NO_BUILD_ERROR_ISSUES` in our
workflows, which will avoid needlessly burning through our rate limit.
MikeMcQuaid
MikeMcQuaid approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Suggested name change.

Library/Homebrew/exceptions.rb Show resolved Hide resolved
@carlocab carlocab merged commit b78f4b9 into master Sep 12, 2024
27 checks passed
@carlocab carlocab deleted the skip-build-error-issues branch September 12, 2024 07:43
carlocab added a commit to Homebrew/homebrew-core that referenced this pull request Sep 12, 2024
@carlocab
dispatch-build-bottle: set HOMEBREW_NO_BUILD_ERROR_ISSUES
13235af 
Companion to Homebrew/brew#18313.
@carlocab carlocab mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlocab @MikeMcQuaid