style: forbid url do
blocks in homebrew/cask
#18404
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #18390
This PR adds a rubocop check that forbids the use of
url do
blocks inhomebrew/cask
. It still allows them to be used in non-official taps. There's a little bit more discussion/context in the PR linked above, but basically these blocks require us to make network calls every time we generate the API data. It's very common for the API generation to fail because one of these URL blocks has an issue, and really the generation should be able to happen offline.This will need to wait for Homebrew/homebrew-cask#186501 to be merged
CC: @Homebrew/cask