Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflows/triage: cleanup usage of CI-linux-self-hosted(-deps)? #191747

Merged
merged 1 commit into from
Sep 25, 2024
Merged

workflows/triage: cleanup usage of CI-linux-self-hosted(-deps)? #191747

merged 1 commit into from
Sep 25, 2024

Conversation

carlocab
Copy link
Member

Now that we skip recursive dependencies on Linux (except for Linux-only
formulae), most of these are not needed. I've retained the formulae that
are Linux-only (alsa-lib, libva, systemd), and ones with more than 200
direct dependents (the rest).

Not really sure what souffle was doing on either list, but we can add
it back if it turns out to be needed.

Finally, I think that this list grew a little out of control, so I've
added @Homebrew/tsc as a CODEOWNER for triage.yml to ensure further
additions are given more careful review.

@carlocab
workflows/triage: cleanup usage of CI-linux-self-hosted(-deps)?
d7681b7 
Now that we skip recursive dependencies on Linux (except for Linux-only
formulae), most of these are not needed. I've retained the formulae that
are Linux-only (alsa-lib, libva, systemd), and ones with more than 200
direct dependents (the rest).

Not really sure what `souffle` was doing on either list, but we can add
it back if it turns out to be needed.

Finally, I think that this list grew a little out of control, so I've
added @Homebrew/tsc as a CODEOWNER for `triage.yml` to ensure further
additions are given more careful review.
@carlocab carlocab requested review from MikeMcQuaid and a team as code owners September 24, 2024 17:18
@github-actions github-actions bot added workflows PR modifies GitHub Actions workflow files automerge-skip `brew pr-automerge` will skip this pull request labels Sep 24, 2024
@cho-m
Copy link
Member

cho-m commented Sep 24, 2024

Some of these were due to disk space, particularly any installation of texlive after GitHub runner was reduced.

@carlocab
Copy link
Member Author

Some of these were due to disk space, particularly any installation of texlive after GitHub runner was reduced.

I've seen texlive succeed on a GitHub-hosted runner. I think it might be sufficient to make sure to test it first if it's being tested. (Or, sort dependents according to bottle size, which probably needs Homebrew/brew#18172)

@carlocab carlocab added this pull request to the merge queue Sep 25, 2024
Merged via the queue into master with commit 1c39678 Sep 25, 2024
20 checks passed
@carlocab carlocab deleted the triage-cleanup branch September 25, 2024 03:01
@MikeMcQuaid
Copy link
Member

Very nice, thanks @carlocab! I like the idea of any more hacks we can make to get more of these things onto GitHub runners.

@carlocab
Copy link
Member Author

I think it might be sufficient to make sure to test it first if it's being tested.

Success 🎉 https:/Homebrew/homebrew-core/actions/runs/11030334118/job/30635055781?pr=191772#step:4:119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

@p-linnane p-linnane p-linnane approved these changes

@MikeMcQuaid MikeMcQuaid Awaiting requested review from MikeMcQuaid MikeMcQuaid is a code owner

Assignees
No one assigned
Labels
automerge-skip `brew pr-automerge` will skip this pull request workflows PR modifies GitHub Actions workflow files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@carlocab @cho-m @MikeMcQuaid @chenrui333 @Rylan12 @p-linnane