Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't put stack trace in the exception message #174

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

zbstof
Copy link

@zbstof zbstof commented Feb 1, 2018

Exception stacktrace for each error could be easily extracted by doing
((FatalTemplateErrorsException) e).getErrors().get(n).getException(),
if needed

Exception stacktrace for each error could be easily extracted by doing
((FatalTemplateErrorsException) e).getErrors().get(n).getException(),
if needed
@zbstof
Copy link
Author

zbstof commented Feb 1, 2018

Problem for us was that we tried extract root cause's message ourselves, and this works ok except with this library, which caused buffer overflow down the line.

@boulter boulter merged commit a99ffdb into HubSpot:master Feb 2, 2018
@boulter
Copy link
Contributor

boulter commented Feb 2, 2018

Thanks, @zbstof!

@zbstof zbstof deleted the shorter-error-message branch February 5, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants