Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null in string exp tests. #278

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Allow null in string exp tests. #278

merged 1 commit into from
Feb 1, 2019

Conversation

mattcoley
Copy link
Collaborator

Previously passing in null would result in an InterpretException being thrown resulting in a template error stating that no argument was passed in. It makes better sense to return false for these tests when a null value is used. I also added tests for both string expression tests.

@codecov-io
Copy link

Codecov Report

Merging #278 into master will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #278      +/-   ##
============================================
+ Coverage     72.32%   72.35%   +0.02%     
- Complexity     1481     1483       +2     
============================================
  Files           231      231              
  Lines          4593     4597       +4     
  Branches        735      737       +2     
============================================
+ Hits           3322     3326       +4     
  Misses         1016     1016              
  Partials        255      255
Impacted Files Coverage Δ Complexity Δ
...njava/lib/exptest/IsStringStartingWithExpTest.java 55.55% <66.66%> (+12.69%) 4 <0> (+1) ⬆️
...jinjava/lib/exptest/IsStringContainingExpTest.java 55.55% <66.66%> (+12.69%) 4 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9095cc3...abd6d4d. Read the comment docs.

@mattcoley mattcoley merged commit d8377d8 into master Feb 1, 2019
@mattcoley mattcoley deleted the fix-string-exp-tests branch February 1, 2019 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants