store reference to TokenScannerSymbols in Nodes and Tokens #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcoley
approved these changes
Apr 2, 2020
|
I apologise. I did not observe that two seperate set of symbols may be used. I thought I had done it successfully. |
Not a problem. |
boulter
deleted the
store-reference-to-TokenScannerSymbols-in-Nodes-and-Tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we would parse nodes and tokens using one set of symbols from the config and potentially use a different set when reconstructing a tag. Instead, let's just store a reference to the symbols on each node so we can use it when rendering.
Follow up to #410
@gabru-md