Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output pyish versions of objects using legacy override flag #621

Merged
merged 4 commits into from
Mar 15, 2021

Conversation

jasmith-hs
Copy link
Contributor

This is mainly a PR for eager execution, but it also refactors the usePyishObjectMapper flag.
Only output the pyish version of an object to the rendered output if usePyishObjectMapper is true. Previously, in eager execution, whenever something like {{ foo }} was rendered, it would output the pyish version. If it were a map, it would look like:

{'a': some a', 'b': 'some b'}

But with default jinjava and the default value for this flag, it would output like:

{a=some a, b=some b}

This PR makes eager execution output respect that flag the same way that default jinjava execution does. usePyishObjectMapper is also refactored to be in the LegacyOverrides builder because it is a legacy functionality override.

@jasmith-hs jasmith-hs merged commit 77a18af into master Mar 15, 2021
@jasmith-hs jasmith-hs deleted the eager-java-like-output branch March 15, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants