fix: data race warnings #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This error occures when there is a mutex in the structure and using a method with a value reviever. In this case the struct will be copied on the method call and it will create a new mutex therefore our previous lock became useless. From the go vet doc: "copylocks: check for locks erroneously passed by value"
pyrooka
commented
Mar 25, 2021
| @@ -129,15 +129,15 @@ func newCloudPakForDataAuthenticatorFromMap(properties map[string]string) (*Clou | |||
| } | |||
|
|
|||
| // AuthenticationType returns the authentication type for this authenticator. | |||
| func (CloudPakForDataAuthenticator) AuthenticationType() string { | |||
There was a problem hiding this comment.
I don't know if is there a specific reason why this used as a value or not, but hopefully changing it to pointer won't break anything. All tests passed btw.
@padamstx What's your take on this?
padamstx
approved these changes
Mar 26, 2021
ibm-devx-automation
pushed a commit
that referenced
this pull request
Mar 30, 2021
|
🎉 This PR is included in version 5.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes arf/planning-sdk-squad#2440
Problem
There were several warnings about race conditions (mostly about the
tokenDatafield) when running the unit tests.Reproduce
go test -tags=all -raceSolution
Introduced "getter" and "setter" functions for the authenticator's
tokenDatawith mutex.