feat: add support for unmarshalling two-dimensional slices of model instances #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkistler
reviewed
Mar 30, 2021
| @@ -50,13 +50,15 @@ func TestUnmarshalPrimitiveString(t *testing.T) { | |||
| "bad_type": true, | |||
There was a problem hiding this comment.
Should there be a variation in this test for [][]string? That is supposed to work, right?
There was a problem hiding this comment.
yep, adding tests for [][] of primitive types now
|
@mkistler I've pushed a new commit that adds tests for two-dimensional arrays of primitive types. |
…nstances This commit improves the model unmarshalling capabilities within the Go core by adding support for an additional pattern ([][]MyModel) within the UnmarshalModel() function. The full set of patterns now supported are: - MyModel (model instance) - map[string]MyModel (map containing model instances) - map[string][]MyModel (map contains slices of model instances - []MyModel (slice of model instances) - new: [][]MyModel (slice of model instance slices)
padamstx
force-pushed
the
two-dim-arrays
branch
from
3bb8065
to
bc688cd
Compare
ibm-devx-automation
pushed a commit
that referenced
this pull request
Mar 30, 2021
# [5.3.0](v5.2.1...v5.3.0) (2021-03-30) ### Features * add support for unmarshalling two-dimensional slices of model instances ([#103](#103)) ([1438a2c](1438a2c))
|
🎉 This PR is included in version 5.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the model unmarshalling capabilities within the Go core
by adding support for an additional pattern ([][]MyModel) within the
UnmarshalModel() function. The full set of patterns now supported are: