Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eliminate goroutine leak in the authenticators #109

Merged
merged 2 commits into from
Apr 22, 2021
Merged

fix: eliminate goroutine leak in the authenticators #109

merged 2 commits into from
Apr 22, 2021

Conversation

pyrooka
Copy link
Member

@pyrooka pyrooka commented Apr 21, 2021

This PR fixes some possible goroutine leak in the authenticators' getToken methods.

Closes #108

@pyrooka pyrooka requested a review from padamstx April 22, 2021 08:52
padamstx
padamstx approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit e5d921a into main Apr 22, 2021
@padamstx padamstx deleted the fix-goroutine-leak branch April 22, 2021 20:34
ibm-devx-sdk pushed a commit that referenced this pull request Apr 23, 2021
@semantic-release-bot
chore(release): 5.4.0 release notes [skip ci]
9d3cec7 
# [5.4.0](v5.3.0...v5.4.0) (2021-04-23)

### Bug Fixes

* eliminate goroutine leak in the authenticators ([#109](#109)) ([e5d921a](e5d921a))

### Features

* add FileWithMetadata type to the core ([#110](#110)) ([c1a4884](c1a4884))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

goroutine leak core.IamAuthenticator
3 participants
@pyrooka @ibm-devx-sdk @padamstx