feat(VpcInstanceAuthenticator): add support for new VPC authentication flow #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
requested review from
dpopp07,
Andras-Csanyi,
barrett-schonefeld and
rmkeezer
padamstx
force-pushed
the
vpc-authenticator
branch
from
d91fe1e
to
dcd4f82
Compare
padamstx
commented
Sep 24, 2021
| "SERVICE7_CLIENT_ID": "iam-client2", | ||
| "SERVICE7_CLIENT_SECRET": "iam-secret2", | ||
| "SERVICE7_SCOPE": "scope2 scope3", | ||
| "SERVICE8_AUTH_TYPE": "VPC", |
There was a problem hiding this comment.
Only added the entries for service8. The rest of the changes are just due to formatting differences.
padamstx
commented
Sep 24, 2021
v5/core/utils_test.go
Outdated
| @@ -491,7 +491,7 @@ func TestConvertSliceBadInput(t *testing.T) { | |||
| assert.Nil(t, convertedSlice) | |||
|
|
|||
| // map[string]byte | |||
| myByteMap := map[string][]byte{"myByteArray": []byte{01, 02, 03, 04}} | |||
| myByteMap := map[string][]byte{"myByteArray": {01, 02, 03, 04}} | |||
There was a problem hiding this comment.
just fixed a warning coming from vscode
padamstx
force-pushed
the
vpc-authenticator
branch
from
dcd4f82
to
0fbeedc
Compare
|
cc: @jorge-ibm for awareness |
padamstx
force-pushed
the
vpc-authenticator
branch
2 times, most recently
from
d5fb1a5
to
a7394a0
Compare
…n flow This commit introduces the VpcInstanceAuthenticator. This authenticator implements the authentication flow within a VPC-managed compute resource that is configured to use the compute resource identity feature. This involves the use of the compute resource's local VPC Instance Metadata Service API to retrieve an instance identity token, and then exchange that token for an IAM access token. The IAM access token is then used to authenticate outbound REST API requests by adding to the request in the Authorization header.
padamstx
force-pushed
the
vpc-authenticator
branch
from
a7394a0
to
8c48338
Compare
padamstx
force-pushed
the
vpc-authenticator
branch
2 times, most recently
from
f109e17
to
6e2d7c6
Compare
padamstx
force-pushed
the
vpc-authenticator
branch
from
6e2d7c6
to
c045311
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Nov 8, 2021
# [5.8.0](v5.7.2...v5.8.0) (2021-11-08) ### Features * **VpcInstanceAuthenticator:** add support for new VPC authentication flow ([#139](#139)) ([9906ab3](9906ab3))
|
🎉 This PR is included in version 5.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the VpcInstanceAuthenticator.
This authenticator implements the authentication flow
within a VPC-managed compute resource that is configured to
use the compute resource identity feature.
This involves the use of the compute resource's local
VPC Instance Metadata Service API to retrieve an instance identity
token, and then exchange that token for an IAM access token.
The IAM access token is then used to authenticate outbound REST
API requests by adding to the request in the Authorization header.