Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Comment Errors #1382

Merged
merged 2 commits into from
Dec 8, 2016
Merged

Post Comment Errors #1382

merged 2 commits into from
Dec 8, 2016

Conversation

rclations
Copy link

What

On at least some post comments, a PHP error is being printed to the front end.

Why

We're using the get_avatar hook, who's third parameter $id_or_email, is specified at A user ID, email address, or comment object.

We are only accommodating for a user ID or email address, and do not have code to accept a comment object.

Reference: https://codex.wordpress.org/Plugin_API/Filter_Reference/get_avatar

The Fix

I've updated the offending function using the example from the codex page to also accept comment objects

@benlk benlk merged commit b60a4e5 into master Dec 8, 2016
@benlk benlk deleted the comment-errors branch February 7, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants