Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove search box from main nav when on the search page. #94

Merged
merged 2 commits into from
Dec 17, 2018
Merged

Remove search box from main nav when on the search page. #94

merged 2 commits into from
Dec 17, 2018

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Dec 17, 2018 •
edited
Loading

Changes

  • Removes the search box from the main nav when on the search page

before:

screen shot 2018-12-17 at 1 20 40 pm

after:
screen shot 2018-12-17 at 1 20 11 pm

Why

Because I noticed the duplication while working on WPBuddy/largo#1602

Questions

  • Are we planning on keeping the main nav search item?
  • should this PR be against a different branch than master? @tylermachado I know you have work going on in Tyler style refresh #93; should this PR be against that branch?

@tylermachado
Copy link

  1. Yes on keeping the main nav search item.
  2. I think so; work continues on that branch at the moment.

@benlk benlk changed the base branch from master to tyler-style-refresh December 17, 2018 18:58
@benlk
Copy link
Collaborator Author

benlk commented Dec 17, 2018

Is it okay to merge this?

tylermachado
tylermachado approved these changes Dec 17, 2018
View reviewed changes
Copy link

@tylermachado tylermachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep!

@benlk benlk merged commit c7c69cd into tyler-style-refresh Dec 17, 2018
This was referenced Dec 17, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylermachado tylermachado tylermachado approved these changes

Assignees
No one assigned
Labels
bug inn.org priority: medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benlk @tylermachado @kaylima