Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide sane defaults for column sizing in Gutenberg #1658

Closed
1 task
benlk opened this issue Apr 5, 2019 · 1 comment
Closed
1 task

Provide sane defaults for column sizing in Gutenberg #1658

benlk opened this issue Apr 5, 2019 · 1 comment
Assignees
@joshdarby
Labels
category: gutenberg Relating to general Gutenberg compatibility category: styles affects lots of styles, requiring visual testing type: bug
Milestone
0.6.2

Comments

@benlk
Copy link
Collaborator

benlk commented Apr 5, 2019 •
edited
Loading

  • make sure columns responsive breakpoints work for Largo's breakpoints

This is because the WP Core blocks stylesheet's breakpoints don't work well for Largo. We should override its rules with our own.

And then we should create an issue for dequeueing the Core blocks stylesheet and replacing it with native Largo styles.
@benlk benlk added type: bug category: styles affects lots of styles, requiring visual testing category: gutenberg Relating to general Gutenberg compatibility labels Apr 5, 2019
@benlk benlk added this to the 0.6.2 milestone Apr 5, 2019
@joshdarby joshdarby self-assigned this Apr 22, 2019
@joshdarby joshdarby mentioned this issue Apr 22, 2019
Merged
@joshdarby
Copy link
Collaborator

@benlk This is in PR #1679.

Before image:
Screen Shot 2019-04-22 at 3 27 38 PM

After image:
Screen Shot 2019-04-22 at 3 27 29 PM

@benlk benlk closed this as completed Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshdarby joshdarby

Labels
category: gutenberg Relating to general Gutenberg compatibility category: styles affects lots of styles, requiring visual testing type: bug
Projects
None yet
Milestone
0.6.2
Development

No branches or pull requests
2 participants
@benlk @joshdarby