Reorder hamburger menu contents; eliminate Global Nav "More" dropdown

[benlk]

Changes

• Updates Largo to Largo 0.6 post-0.6.1, after Fix for #1624 and #1623: Bootstrap_Nav_Walker::start_el() continued WPBuddy/largo#1625
• Creates a new partials/nav-sticky.php in order to bust the Global Nav items out from under the main nav.

Why

For #12

[benlk]

The change in this branch in 85daad2 does put the contents of the global nav before the contents of the main nav in the hamburger-menu-controlled menu on mobile, but because that menu shares markup with the sticky nav, the sticky nav also displays the global nav contents before the main nav's contents.

Here's how it looks now:

And here's how it looks with 85daad2

Questions for @khantasha:

• Can the global nav come at the end of the hamburger menu instead?

[khantasha]

If I'm understanding this right, I think it's fine to put the global nav after the main nav in mobile as long as it's no longer contained within the More menu.

…

On Mon, Feb 4, 2019 at 7:56 PM Ben Keith ***@***.***> wrote: The change in this branch in 85daad2 <85daad2> does put the contents of the global nav before the contents of the main nav in the hamburger-menu-controlled menu on mobile, but because that menu shares markup with the sticky nav, the sticky nav also displays the global nav contents before the main nav's contents. Here's how it looks now: [image: screen shot 2019-02-04 at 7 01 10 pm] <https://user-images.githubusercontent.com/1754187/52245346-485db780-28af-11e9-9248-fbd11f46dd6a.png> And here's how it looks with 85daad2 <85daad2> [image: screen shot 2019-02-04 at 4 00 58 pm] <https://user-images.githubusercontent.com/1754187/52241309-4d1b6f00-28a1-11e9-87e3-b3e5d793d8b4.png> [image: screen shot 2019-02-04 at 4 01 18 pm] <https://user-images.githubusercontent.com/1754187/52241310-4d1b6f00-28a1-11e9-9fc8-86a36605e3a3.png> Questions for @khantasha <https:/khantasha>: - Can the global nav come at the end of the hamburger menu instead? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21 (comment)>, or mute the thread <https:/notifications/unsubscribe-auth/AFDU-dSAOtm1GlEi1U4ubfKlP9xfTfgmks5vKNbMgaJpZM4aiKSO> .

-- Natasha Vicens Interactives & Design Editor, PublicSource 746 E. Warrington Ave. Pittsburgh, PA 15210 @khantasha <https://twitter.com/khantasha> Get the latest news from PublicSource: publicsource.org/newsletter/subscriptions <http://publicsource.org/newsletter-signup> Follow us on Twitter: twitter.com/publicsourcepa Be our fan on Facebook: facebook.com/publicsourcepa <http://www.facebook.com/publicsource?ref=hl>

[benlk]

If we change the mobile nav, the sticky nav also changes. Here's what it looks like with the global nav contents positioned after the main nav contents:

Note that the former "more" menu contents are now just part of that bar's contents; the "More" menu shown is the overflow menu item that appears when the menu would be too long to fit within the viewport.

The sticky nav is the mobile nav; the display presentation changes based on the screen width.

Is this okay? @khantasha

[khantasha]

Yes, that's fine. Just fyi, his looks like a really old nav we had awhile ago, the nav options are much shorter now so the display should be fine.

…

On Tue, Feb 5, 2019 at 2:34 PM Ben Keith ***@***.***> wrote: If we change the mobile nav, the sticky nav also changes. Here's what it looks like with the global nav contents positioned after the main nav contents: [image: screen shot 2019-02-05 at 11 03 45 am] <https://user-images.githubusercontent.com/1754187/52289366-e13a1480-293b-11e9-8e10-7064d72b981e.png> Note that the former "more" menu contents are now just part of that bar's contents; the "More" menu shown is the overflow menu item that appears when the menu would be too long to fit within the viewport. [image: screen shot 2019-02-05 at 11 48 26 am] <https://user-images.githubusercontent.com/1754187/52289436-062e8780-293c-11e9-9cfc-13c53b689bd8.png> The sticky nav is the mobile nav; the display presentation changes based on the screen width. Is this okay? @khantasha <https:/khantasha> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21 (comment)>, or mute the thread <https:/notifications/unsubscribe-auth/AFDU-apcg0i64NWDSf2cElg3KZYN2Q2cks5vKdzKgaJpZM4aiKSO> .

-- Natasha Vicens Interactives & Design Editor, PublicSource 746 E. Warrington Ave. Pittsburgh, PA 15210 @khantasha <https://twitter.com/khantasha> Get the latest news from PublicSource: publicsource.org/newsletter/subscriptions <http://publicsource.org/newsletter-signup> Follow us on Twitter: twitter.com/publicsourcepa Be our fan on Facebook: facebook.com/publicsourcepa <http://www.facebook.com/publicsource?ref=hl>