Support publish dataset with update current version #166
Conversation
g-saracca
added
Size: 3
|
|
||
| is successful, the use case does not return the dataset object, but the HTTP status code `200`. Otherwise, it throws an error.\ | ||
| If you want to perform a major version update, you must set the `versionUpdateType` parameter to `VersionUpdateType.MAJOR`.\ | ||
| Superusers can pass `VersionUpdateType.UPDATE_CURRENT` to update metadata without changing the version number. This will overwrite the latest published version and therefore will only work for a dataset that has been published at least once. \*Note that this will only work also if there were no file changes in the update.\ | ||
| The `datasetId` parameter can be a string, for persistent identifiers, or a number, for numeric identifiers. |
There was a problem hiding this comment.
I know we haven't worked on permissions yet generally, but it could be good to add a comment that UPDATE_CURRENT is only available to 'superuser' accounts, since it's more of a special case than other permissions logic. But if we want to wait till later, that's ok.
There was a problem hiding this comment.
Hi @ekraffmiller , I think that is exactly what I added in the docs here:
Superusers can pass
VersionUpdateType.UPDATE_CURRENTto update metadata without changing the version number. This will overwrite the latest published version and therefore will only work for a dataset that has been published at least once. *Note that this will only work also if there were no file changes in the update.
Or were you thinking about something different? I ask about this on the dv-rearchitecture-frontend channel.
There was a problem hiding this comment.
Oh, I'm sorry, I misread that comment in the doc! Yes, that looks perfect. :)
What this PR does / why we need it:
Adds support to publish dataset use case updating current version for superusers.
Which issue(s) this PR closes:
Special notes for your reviewer:
The
.gitignoremodification is to ignore my vscode folder on my end where I'm using settings to auto format on save with prettier.Suggestions on how to test this:
Visual inspection and run tests.
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A