347 Add eslint plugin react hooks

[g-saracca]

What this PR does / why we need it:

Adds Eslint plugin for React Hooks.
We need it to enforce Rules of Hooks.

Which issue(s) this PR closes:

• Closes Add eslint-plugin-react-hooks #347

Special notes for your reviewer:

The plugin raised only a few errors when initially configured, only related to calling hooks conditionally, all were resolved.
There are several minor warnings that we could fix as we come across them.
I only hide via a comment of eslint two errors regarding the use of a hook in the Story of the DatasetAlert as I think it might take more time than expected and it is just a story, however we could see how to configure the alerts story to avoid the eslint error in the future.

Suggestions on how to test this:

• Run tests to check everything works as usual.
• Locate a useEffect call after a conditional statement in a react component, it should show an eslint error.
• Use a local state variable or a prop inside a useEffect and don't add it to the dependency array of it, it should show an eslint warning.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

No

Additional documentation:

[MellyGray]

Looks good, thanks for adding the plugin!

I just think that fixing all the ESLint errors or warnings related to the new plugin should be within the scope of this issue. Adding a plugin doesn't mean much if we leave the code with errors. What truly adds value is addressing and resolving all these issues

[g-saracca]

Yes, it makes total sense, we could tackle those warnings as well. I'm going to resize this issue due to the large amount of warnings received about incorrect dependencies in useEffect which is something I need to be careful with because otherwise we can end up in infinite loops, multiple calls to the api or unnecessary re-renders.

[coveralls]

coverage: 97.83% (+0.001%) from 97.829%
when pulling fafc7a6 on feature/347-eslint-plugin-react-hooks
into 2ace63e on develop.

[g-saracca]

As discussed with the team, we thought the best idea would be to resolve the remaining warnings in a separate issue.
At the moment we dropped from having 7 errors and 24 warnings to only 8 warnings and no errors. ✅

I have created a new issue to resolve the remaining issues/warnings.
#386

[g-saracca]

Added waiting tag, might be good to wait to merge this issue until we get the e2e tests fixed.

[g-saracca]

Hi @MellyGray , I update the branch with the fix of the e2e tests, both unit and e2e tests are passing 🎉 .
You can retake the review of this PR again now, thanks!