Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

315 - Developer guide: Architecture design methodology #361

Merged

Conversation

MellyGray
Copy link
Contributor

@MellyGray MellyGray commented Apr 4, 2024

What this PR does / why we need it:

This PR adds a new section to the Developer Guider about the Architecture design methodology

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Go to the DEVELOPER GUIDE and check the new section.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

New section to the Developer Guider about the Architecture design methodology

Additional documentation:

@MellyGray MellyGray linked an issue Apr 4, 2024 that may be closed by this pull request
@MellyGray MellyGray changed the base branch from develop to docs/26-add-frontend-guides April 4, 2024 16:21
@coveralls
Copy link

coveralls commented Apr 5, 2024

Coverage Status

coverage: 97.495%. remained the same
when pulling c327a61 on 315-feat-developer-guide-architecture-design-methodology
into 24b8ff0 on develop.

@MellyGray MellyGray marked this pull request as ready for review April 8, 2024 09:00
@MellyGray MellyGray added Size: 3 A percentage of a sprint. 2.1 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows SPA: Documentation Milestone tag for all SPA-related documenting tasks labels Apr 8, 2024
@ekraffmiller ekraffmiller self-assigned this Apr 11, 2024
ekraffmiller
ekraffmiller previously approved these changes Apr 15, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @MellyGray!

Base automatically changed from docs/26-add-frontend-guides to develop April 17, 2024 18:11
@g-saracca g-saracca dismissed ekraffmiller’s stale review April 17, 2024 18:11

The base branch was changed.

@pdurbin
Copy link
Member

pdurbin commented Apr 17, 2024

@MellyGray heads up that there are merge conflicts.

…into 315-feat-developer-guide-architecture-design-methodology
@ekraffmiller
Copy link
Contributor

reviewed again after merge, looks good 👍

Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scolapasta scolapasta merged commit 620e31b into develop Apr 18, 2024
11 of 14 checks passed
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
…ecture-design-methodology

315 - Developer guide: Architecture design methodology
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. SPA: Documentation Milestone tag for all SPA-related documenting tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spike - Developer Guide] Breakdown of architecture design methodology
5 participants