Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PR triggers to github action workflows #401

Merged
merged 5 commits into from
May 29, 2024

Conversation

ekraffmiller
Copy link
Contributor

@ekraffmiller ekraffmiller commented May 20, 2024

What this PR does / why we need it:
These are updates to our github actions to trigger test workflows when a PR is opened. The PR triggers will not run automatically for new external contributors - to run them we can start them manually in the PR.

Which issue(s) this PR closes:

Closes #398

Special notes for your reviewer:
I mislabeled the branch - it should be 398-pr-workflow-trigger, not 400

Suggestions on how to test this:
To recreate the use case, open a PR from a forked repository. For an current contributor, that should trigger the workflows, for a new contributor, a button in the "Conversations" tab of the PR should contain a button to manually trigger the workflows.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no

Is there a release notes update needed for this change?:
no
Additional documentation:

@coveralls
Copy link

coveralls commented May 20, 2024

Coverage Status

coverage: 97.426% (-0.4%) from 97.829%
when pulling 2abdd52 on feature/400-pr-workflow-trigger
into 2ace63e on develop.

@ekraffmiller ekraffmiller added pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. labels May 20, 2024
@ekraffmiller ekraffmiller marked this pull request as ready for review May 20, 2024 19:21
@ekraffmiller ekraffmiller changed the title feat: add PR trigger to accessibility.yml add PR triggers to github action workflows May 20, 2024
@g-saracca g-saracca assigned g-saracca and unassigned g-saracca May 20, 2024
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add this functionality also for the test workflow?

@ekraffmiller
Copy link
Contributor Author

ekraffmiller commented May 21, 2024

Shouldn't we add this functionality also for the test workflow?

yes, thanks for catching that! I didn't add it to the deploy workflows however, since I thought that could skipped (and they are only triggered manually)

@g-saracca g-saracca removed their assignment May 21, 2024
@GPortas GPortas self-assigned this May 29, 2024
@GPortas GPortas merged commit e3224b1 into develop May 29, 2024
20 checks passed
@GPortas GPortas deleted the feature/400-pr-workflow-trigger branch May 29, 2024 08:56
jayanthkomarraju pushed a commit to jayanthkomarraju/dataverse-frontend that referenced this pull request May 31, 2024
add PR triggers to github action workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update Github actions so they are triggered from opening a Pull Request
4 participants