fix: map jsDataset.id and persistentId in JSDatasetMapper.toHierarachy() #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekraffmiller
added
pm.GREI-d-2.7.1
g-saracca
approved these changes
May 22, 2024
There was a problem hiding this comment.
Thanks @ekraffmiller , nice catch! I am directly mergin this into the feature branch!
g-saracca
merged commit e5b6780
into
feature/380-extend-breadcrumbsgenerator-for-action-items
10 of 13 checks passed
jayanthkomarraju
pushed a commit
to jayanthkomarraju/dataverse-frontend
that referenced
this pull request
May 31, 2024
fix: map jsDataset.id and persistentId in JSDatasetMapper.toHierarachy()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fix the mapping of Hierarchy in the getDataset() usecase
Which issue(s) this PR closes:
Closes #403
Special notes for your reviewer:
I think this is the fix that is needed rather than IQSS/dataverse-client-javascript#154.
Suggestions on how to test this:
In the SPA, create a Dataset, then go to File Upload page. The Dataset Breadcrumb on the File upload page should have the correct link.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: