Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put modifiers in the correct order #10075

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

bencomp
Copy link
Contributor

@bencomp bencomp commented Oct 31, 2023

What this PR does / why we need it:
This PR replaces final static with static final to comply with the Java Language Specification. It is a small step towards more consistent code.
While working in the affected files, I replaced a few calls to deprecated new Integer(String) and new Long(String) constructors with Integer.valueOf(String) and Long.valueOf(String) static method calls.

Which issue(s) this PR closes:

Closes #10074

Special notes for your reviewer:
Thank you for reviewing!

Suggestions on how to test this:
None. Perhaps in the future a Checkstyle run could fail if the order is incorrect.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.

Is there a release notes update needed for this change?:
No.

Additional documentation:
Also linked from the issue: Sonarcloud on why and how to put modifiers in the correct order

@pdurbin pdurbin added Size: 10 A percentage of a sprint. 7 hours. Component: Code Infrastructure formerly "Feature: Code Infrastructure" labels Feb 28, 2024
@coveralls
Copy link

Coverage Status

coverage: 20.659%. remained the same
when pulling 4715eef on bencomp:10074-modifiers
into d113d7c on IQSS:develop.

@sekmiller
Copy link
Contributor

@bencomp thanks for this. We'd like to get this into This Sprint. Please update your branch from dev and resolve the merge conflict. Thanks!

Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@qqmyers qqmyers added Size: 0.5 A percentage of a sprint. 0.35 hours and removed Size: 10 A percentage of a sprint. 7 hours. labels Oct 9, 2024
@cmbz cmbz added the FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) label Oct 9, 2024
@bencomp
Copy link
Contributor Author

bencomp commented Oct 9, 2024

@sekmiller I don't know if I'm in time for this sprint, but I updated the branch.

@pdurbin pdurbin added the Type: Bug a defect label Oct 9, 2024
@coveralls
Copy link

Coverage Status

coverage: 20.875% (-0.3%) from 21.137%
when pulling a32b9ed on bencomp:10074-modifiers
into 45bdf5a on IQSS:develop.

@ofahimIQSS
Copy link
Contributor

@bencomp Can you please add steps to test this ticket?

@bencomp
Copy link
Contributor Author

bencomp commented Oct 10, 2024

This PR is basically about code style; no functionality changed and hence there's not really anything to test. Most importantly the code should compile as normal.

If you want an analysis of the changes, you could use the Sonar Maven goal and Sonarcloud to see that the warnings about modifier order (should) have gone away. @pdurbin and @poikilotherm have some experience with these steps.

@ofahimIQSS ofahimIQSS self-assigned this Oct 10, 2024
@ofahimIQSS
Copy link
Contributor

ofahimIQSS commented Oct 10, 2024

Performed smoke test on internal-dataverse and no issues were observed. Merging pull request

@ofahimIQSS ofahimIQSS merged commit c44ad65 into IQSS:develop Oct 10, 2024
11 checks passed
@ofahimIQSS ofahimIQSS removed their assignment Oct 10, 2024
@pdurbin pdurbin added this to the 6.5 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) Size: 0.5 A percentage of a sprint. 0.35 hours Type: Bug a defect
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Code style (Sonarlint): put public static final modifiers in the correct order
7 participants