Put modifiers in the correct order #10075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR replaces
final static
withstatic final
to comply with the Java Language Specification. It is a small step towards more consistent code.While working in the affected files, I replaced a few calls to deprecated
new Integer(String)
andnew Long(String)
constructors withInteger.valueOf(String)
andLong.valueOf(String)
static method calls.Which issue(s) this PR closes:
Closes #10074
Special notes for your reviewer:
Thank you for reviewing!
Suggestions on how to test this:
None. Perhaps in the future a Checkstyle run could fail if the order is incorrect.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
No.
Additional documentation:
Also linked from the issue: Sonarcloud on why and how to put modifiers in the correct order