10207 bug api datasets versions latest fix #10212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sekmiller
reviewed
Jan 8, 2024
sekmiller
reviewed
Jan 9, 2024
...a/edu/harvard/iq/dataverse/engine/command/impl/GetLatestAccessibleDatasetVersionCommand.java
Show resolved
Hide resolved
sekmiller
requested changes
Jan 9, 2024
This comment has been minimized.
This comment has been minimized.
sekmiller
approved these changes
Jan 10, 2024
GPortas
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Looks good!
I have tested all version identifiers and it works properly.
In particular, the following call using :latest, which was the one problematic, now works as expected:
curl -X GET "http://localhost:8080/api/v1/datasets/:persistentId/versions/:latest?persistentId=doi:10.5072/FK2/EFWQDI&includeDeaccessioned=true&excludeFiles=true"
I wanted to add a refactor suggestion to my PR review, but GitHub doesn't seem to allow adding suggestions when they involve big changes to the file. So I created a PR pointing to your branch: #10267
This comment has been minimized.
This comment has been minimized.
…ed-dsv-cmd #10212 PR refactor proposal for GetLatestPublishedDatasetVersionCommand
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
sekmiller
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It was reported on #10164 that the API to get a dataset version was not working as intended. Part of this was fixed on #10191 but this PR didn't address when the request is made using the parameter ":latest" Some other cases like "latest-published" were addressed because of how the code was structured.
Which issue(s) this PR closes:
Closes #10207
Special notes for your reviewer:
As part of the fix several test cases were added to verify the right behavior of the API, some of them can seem redundant but there are slight differences, for example, if you use ":latest" on a request that includes deaccessioned but there is a Draft and you will get the Draft version and depending if you requested the files you may get them or not. I am happy to get on a call and explain the cases but also I am open to suggestions.
Suggestions on how to test this:
Similar to the testing done on #10164 but besides targeting a specific version replace with :latest
As an example
curl -X GET "https://beta.dataverse.org/api/v1/datasets/:persistentId/versions/:latest?persistentId=doi:10.5072/FK2/UBKVYE&includeDeaccessioned=true&excludeFiles=true"