Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displayOnCreate set to true for depositor and dateOfDeposit in Citation metadata block #10884

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Sep 26, 2024

What this PR does / why we need it:

The fields depositor and dateOfDeposit in the citation.tsv metadatablock have been updated to have the property displayOnCreate set to TRUE.

Which issue(s) this PR closes:

Closes #10850

Suggestions on how to test this:

  1. Test the metadatablocks API method to retrieve all metadata blocks and their fields with onlyDisplayedOnCreate=true:

curl "$SERVER_URL/api/metadatablocks?returnDatasetFieldTypes=true&onlyDisplayedOnCreate=true"

Verify that within the citation metadata block, depositor and dateOfDeposit are now retrieved.

  1. Visual inspection of the updated MetadataBlocksIT test on: 13201dc

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

Yes, attached.

Special notes:

When using the generated docker image from this PR in the SPA, the fields depositor and dateOfDeposit are displayed on dataset creation, as in JSF:

Screenshot 2024-09-26 at 09 55 32

@coveralls
Copy link

coveralls commented Sep 26, 2024

Coverage Status

coverage: 20.872%. remained the same
when pulling 1feee4d on 10850-citation-tsv-displayoncreate-depositor-dateofdeposit
into 050064e on develop.

This comment has been minimized.

@GPortas GPortas added Size: 3 A percentage of a sprint. 2.1 hours. SPA These changes are required for the Dataverse SPA GREI Re-arch Issues related to the GREI Dataverse rearchitecture SPA.Q3 Not related to any specific Q3 feature labels Sep 26, 2024
@GPortas GPortas marked this pull request as ready for review September 26, 2024 08:01
@GPortas GPortas added Size: 0.5 A percentage of a sprint. 0.35 hours and removed Size: 3 A percentage of a sprint. 2.1 hours. labels Sep 26, 2024

This comment has been minimized.

1 similar comment
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10850-citation-tsv-displayoncreate-depositor-dateofdeposit
ghcr.io/gdcc/configbaker:10850-citation-tsv-displayoncreate-depositor-dateofdeposit

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Copy link
Contributor

@scolapasta scolapasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GPortas looks good - just a quick question (that shouldn't block this moving forward), in the SPA, are you pre populating the fields (as in the JSF) with the user / current date? If not, should that be a new issue?

@GPortas
Copy link
Contributor Author

GPortas commented Sep 27, 2024

@GPortas looks good - just a quick question (that shouldn't block this moving forward), in the SPA, are you pre populating the fields (as in the JSF) with the user / current date? If not, should that be a new issue?

@scolapasta Currently we are not pre populating them, since we needed this API change to make these fields appear in the dataset creation form.

Our plan was to work on it once this API extension was ready. I have created an issue for it: IQSS/dataverse-frontend#510

@stevenwinship stevenwinship self-assigned this Sep 27, 2024
@stevenwinship stevenwinship merged commit 0686077 into develop Sep 27, 2024
13 checks passed
@stevenwinship stevenwinship deleted the 10850-citation-tsv-displayoncreate-depositor-dateofdeposit branch September 27, 2024 14:05
@stevenwinship stevenwinship removed their assignment Sep 27, 2024
@pdurbin pdurbin modified the milestone: 6.4 Sep 27, 2024
@cmbz cmbz added the FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Original size: 0.5 Size: 0.5 A percentage of a sprint. 0.35 hours SPA.Q3 Not related to any specific Q3 feature SPA These changes are required for the Dataverse SPA
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Citation.tsv: set displayOnCreate=TRUE for depositor and dateOfDeposit
6 participants