Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replacing tsup with rollup #65

Merged
merged 3 commits into from
Oct 8, 2024
Merged

feat: replacing tsup with rollup #65

merged 3 commits into from
Oct 8, 2024

Conversation

ITZSHOAIB
Copy link
Owner

Description

Previously we were using tsup to build our package and using tsup it was harder to manage commonJS modules due to different reasons. Also the build size was not minimized properly. Now with rollup and terser, we will be able to build our package in esm and cjs very easily with terser's minification capabilities. And the declaration files and declaration map files will be seperately in types folder which will help end users to navigate to our actual source code through IDE inspite of our main build is super minified.

Related Issues

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have checked that there isn't already a PR that solves the problem the same way.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have included a changeset according to the type of my changes

Additional Context or Notes

  • Is there anything specific the reviewer should focus on?

Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: 2d66735

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
chukti Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chukti ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 6:57pm

@ITZSHOAIB ITZSHOAIB merged commit 1d01d30 into master Oct 8, 2024
4 checks passed
@ITZSHOAIB ITZSHOAIB deleted the ss-rollup branch October 8, 2024 05:46
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: try replacing tsup with rollup and terser
2 participants