forked from elastic/beats
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update Kafka version parsing / supported range (elastic#27720)
- Loading branch information
Showing
5 changed files
with
133 additions
and
69 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| // Licensed to Elasticsearch B.V. under one or more contributor | ||
| // license agreements. See the NOTICE file distributed with | ||
| // this work for additional information regarding copyright | ||
| // ownership. Elasticsearch B.V. licenses this file to you under | ||
| // the Apache License, Version 2.0 (the "License"); you may | ||
| // not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package kafka | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| "github.com/Shopify/sarama" | ||
| ) | ||
|
|
||
| func TestVersionGet(t *testing.T) { | ||
| valid := map[Version]sarama.KafkaVersion{ | ||
| "0.11": sarama.V0_11_0_2, | ||
| "1": sarama.V1_1_1_0, | ||
| "2.0.0": sarama.V2_0_0_0, | ||
| "2.0.1": sarama.V2_0_1_0, | ||
| "2.0": sarama.V2_0_1_0, | ||
| "2.5": sarama.V2_5_0_0, | ||
| } | ||
| invalid := []Version{ | ||
| "1.1.2", | ||
| "1.2.3", | ||
| "1.3", | ||
| "hello", | ||
| "2.0.3", | ||
| } | ||
| for s, expect := range valid { | ||
| got, ok := s.Get() | ||
| if !ok { | ||
| t.Errorf("'%v' should parse as Kafka version %v, got nothing", | ||
| s, expect) | ||
| } else if got != expect { | ||
| t.Errorf("'%v' should parse as Kafka version %v, got %v", | ||
| s, expect, got) | ||
| } | ||
| } | ||
| for _, s := range invalid { | ||
| got, ok := s.Get() | ||
| if ok { | ||
| t.Errorf("'%v' is not a valid Kafka version but parsed as %v", | ||
| s, got) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func TestSaramaUpdate(t *testing.T) { | ||
| // If any of these versions are considered valid by our parsing code, | ||
| // it means someone updated sarama without updating the parsing code | ||
| // for the new version. Gently remind them. | ||
| flagVersions := []Version{"2.8.1", "2.9.0"} | ||
| for _, v := range flagVersions { | ||
| if _, ok := v.Get(); ok { | ||
| t.Fatalf( | ||
| "Kafka version %v is now considered valid. Did you update Sarama?\n"+ | ||
| "If so, remember to:\n"+ | ||
| "- Update truncatedKafkaVersions in libbeat/common/kafka/version.go\n"+ | ||
| "- Update the documentation to list the latest version:\n"+ | ||
| " * libbeat/outputs/kafka/docs/kafka.asciidoc\n"+ | ||
| " * filebeat/docs/inputs/inputs-kafka.asciidoc\n"+ | ||
| "- Update TestSaramaUpdate in libbeat/common/kafka/version_test.go\n", | ||
| v) | ||
|
|
||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters