forked from WebKit/WebKit-http
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge r205200 - [[Delete]] should throw for cross-origin Window / Loc…
…ation objects https://bugs.webkit.org/show_bug.cgi?id=161397 Reviewed by Ryosuke Niwa. Source/WebCore: [[Delete]] should throw for cross-origin Window / Location objects: - whatwg/html#1728 Firefox and Chrome already throw. Previously, WebKit was merely ignoring the call and logging an error message. No new tests, updated existing test. * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::deleteProperty): (WebCore::JSDOMWindow::deletePropertyByIndex): * bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::deleteProperty): (WebCore::JSLocation::deletePropertyByIndex): LayoutTests: Update / rebaseline existing test to reflect behavior change. * http/tests/security/cross-frame-access-delete-expected.txt: * http/tests/security/cross-frame-access-delete.html: * http/tests/security/resources/cross-frame-iframe-for-delete-test.html: git-svn-id: http://svn.webkit.org/repository/webkit/releases/WebKitGTK/webkit-2.14@205596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- Loading branch information
1 parent
8c27f3d
commit 2843f66
Showing
7 changed files
with
69 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,16 @@ | ||
2016-08-30 Chris Dumez <[email protected]> | ||
|
||
[[Delete]] should throw for cross-origin Window / Location objects | ||
https://bugs.webkit.org/show_bug.cgi?id=161397 | ||
|
||
Reviewed by Ryosuke Niwa. | ||
|
||
Update / rebaseline existing test to reflect behavior change. | ||
|
||
* http/tests/security/cross-frame-access-delete-expected.txt: | ||
* http/tests/security/cross-frame-access-delete.html: | ||
* http/tests/security/resources/cross-frame-iframe-for-delete-test.html: | ||
|
||
2016-08-30 Zalan Bujtas <[email protected]> | ||
|
||
ASSERTION FAILED: opportunitiesInRun <= expansionOpportunityCount in WebCore::computeExpansionForJustifiedText | ||
|
24 changes: 15 additions & 9 deletions
24
LayoutTests/http/tests/security/cross-frame-access-delete-expected.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,25 @@ | ||
2016-08-30 Chris Dumez <[email protected]> | ||
|
||
[[Delete]] should throw for cross-origin Window / Location objects | ||
https://bugs.webkit.org/show_bug.cgi?id=161397 | ||
|
||
Reviewed by Ryosuke Niwa. | ||
|
||
[[Delete]] should throw for cross-origin Window / Location objects: | ||
- https:/whatwg/html/pull/1728 | ||
|
||
Firefox and Chrome already throw. Previously, WebKit was merely | ||
ignoring the call and logging an error message. | ||
|
||
No new tests, updated existing test. | ||
|
||
* bindings/js/JSDOMWindowCustom.cpp: | ||
(WebCore::JSDOMWindow::deleteProperty): | ||
(WebCore::JSDOMWindow::deletePropertyByIndex): | ||
* bindings/js/JSLocationCustom.cpp: | ||
(WebCore::JSLocation::deleteProperty): | ||
(WebCore::JSLocation::deletePropertyByIndex): | ||
|
||
2016-08-30 Mark Lam <[email protected]> | ||
|
||
Introduce the ThrowScope and force every throw site to instantiate a ThrowScope. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters