Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle): Change the way how the dropdown passes size to toggle #14634

Merged
merged 10 commits into from
Sep 16, 2024

Conversation

mddragnev
Copy link
Member

Closes #14618
Removing the size input because when action strip is creating/destroying on mouse move between the rows it creates and destroys a dropdown within the actionstrip which causes the error.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@mddragnev mddragnev marked this pull request as ready for review August 19, 2024 12:10
Copy link
Contributor

@wnvko wnvko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please name your PRs with some descriptive names. Having something like this is really far away from helpfull:
image

@mddragnev mddragnev requested a review from wnvko August 20, 2024 07:02
Copy link
Contributor

@wnvko wnvko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add also test for this change

@mddragnev
Copy link
Member Author

@wnvko There are couple of tests that use that inline style to see whether the items in the dropdown are correctly sized so I dont think it is neccessary to write another one which is just checking whether the list has size when I did not only delete it but just changed that the sizing is set to its parent container. I would be testing css inheritance this way.

Copy link
Member

@damyanpetev damyanpetev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only test I think we might want to add for this is an explicit cover of the overlay functionality that moves the computed size var (similar to the width/height, guessing there is one). There might be some that indirectly go though the logic, but I' not sure they guarantee this works

@IMinchev64 IMinchev64 added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Sep 10, 2024
@dkamburov dkamburov merged commit f8fb782 into 18.1.x Sep 16, 2024
4 checks passed
@dkamburov dkamburov deleted the mdragnev/fix-14618-18.1.x branch September 16, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dropdown toggle version: 18.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExpressionChangedAfterItHasBeenCheckedError when setting the size of the action strip
6 participants