Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Andromeda description and add centralized dev instructions #80

Merged
merged 11 commits into from
Jan 29, 2024

Conversation

egrace479
Copy link
Member

Added a more full description of Andromeda (the package in the repo and the tool itself). Also added the directions to run Andromeda locally to the main repo README so they're not split between two README's in separate folders.

@egrace479 egrace479 added the documentation Improvements or additions to documentation label Nov 2, 2023
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@egrace479
Copy link
Member Author

egrace479 commented Dec 5, 2023

Added a CITATION.cff file with references to the original and a more recent Andromeda paper that Chris North pointed us to in April. Also references the source repo and another that I referenced in re-working the code.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments and suggestions.

CITATION.cff Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
egrace479 and others added 4 commits December 6, 2023 10:24
…23 work.

This is following response from lab PI (Chris North) on appropriate licensing for andromeda source materials.
README.md Outdated Show resolved Hide resolved
Co-authored-by: House <[email protected]>
Copy link
Collaborator

@johnbradley johnbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline suggestion. I don't feel strongly enough about the issue that I would object to duplicating executable steps here, so I'll approve this here regardless of whether you decide to change it or not.

2. Frontend nodejs/react development server

For instructions on buliding and running the Docker container see [Developing with Docker](https:/Imageomics/Andromeda/wiki/Developing-with-Docker).
1. Python Flask Backend API Server: navigate to the `andromeda` folder and run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether we shouldn't simply defer to the subsequently mentioned subfolder README for all executable instructions, to prevent these from accidentally diverging in the future (and to prevent unintended mistakes, such as implicitly disabling CORS when that wasn't expected).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this into the main README, since otherwise you have to go to two separate subfolder READMEs to get instructions for running locally, which can complicate what is otherwise a simple process.

@egrace479 egrace479 merged commit 9e2285f into main Jan 29, 2024
1 check passed
@egrace479 egrace479 mentioned this pull request Feb 2, 2024
3 tasks
@egrace479 egrace479 deleted the docs/description branch July 19, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants