Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain hidden columns #91

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Explain hidden columns #91

merged 1 commit into from
Feb 29, 2024

Conversation

johnbradley
Copy link
Collaborator

Adds note explaining that columns incompatible with WMDS are excluded.

Fixes #68

Adds note explaining that columns incompatible with WMDS are excluded.

Fixes #68
@egrace479
Copy link
Member

It seems this note pops up regardless of whether columns are indeed dropped (presumably a test would be more difficult and not worth the hassle, especially since the image label and URL will always be non-numeric).

Looks good regardless, and is a nice reminder for people.

Copy link
Member

@egrace479 egrace479 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnbradley johnbradley merged commit 94af757 into main Feb 29, 2024
2 checks passed
@johnbradley johnbradley deleted the 68-hidden-columns branch February 29, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inform users why columns are excluded
3 participants