-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for WADO-URI #53
Comments
So far, we only considered the RESTful Web Services and ignored the URI Web Service. I am not sure whether we should try to integrate both services in the exiting class, given that the URI service only supports retrieve transactions, but not the search and store transactions. Furthermore, the retrieve transaction of the URI service only supports retrieval at the instance level (and to a certain extent at the frame level, but only a single frame can be retrieved per request). Therefore, the only methods that are useful for the URI Service are If we think that it would be valuable to add support for the URI Web Service to the library, I would suggest implementing a separate class (e.g., |
Thanks for the reply, these are good points. I will play around with creating a |
Have you considered leveraging a DIMSE/DICOMweb adapter (if you're able to deploy server-side)? |
We have a need to deal with some equipment that does not expose its full WADO functionality through WADA-RS and requires the use of WADO-URI for some WADO features.
Would you entertain a PR that adds support for the WADO-URI? I think this should be pretty straightforward to implement and we would be happy to work on it.
If so, I would appreciate your thoughts on how the API could look. I envision that we would add the option to use WADO-URI to the existing
retrieve_...
methods. This could be done either as an optional parameter to the relevant methods, or as a global configuration option in the client's constructor. I think I favour the former despite it being more verbose. Thoughts? @hackermdThe text was updated successfully, but these errors were encountered: