Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific month and day doc type aliases used when creating #4

Draft
wants to merge 1 commit into
base: v11/develop
Choose a base branch
from

Conversation

LottePitcher
Copy link

Hey @D-Inventor!

I am raising this as a draft PR in case you have any input on the approach I'm taking for issue #3.

I have got as far as updating the code for the creation of new items. My next step is to update the code for the saving of existing items, and then finally to check the two recycle bin related notification handlers.

This has been tested on a v11 site, both with the new feature (i.e. with MonthFolderDocType and DayFolderDocType options configured) and without (i.e. the way you had previously).

Whilst I've been working on this I also did a bit of consolidating of the readme instructions:

  • There were a couple of rogue 'DateFolderDocType' entries (should be 'FolderDocType')
  • I changed the example ItemDocType alias to 'blogpost' as the AllowedParentDocTypes is set to 'blog'. I think blog posts are also a more likely use case than someone using it for a generically named doc type such as 'contentPage'

I checked Infocaster's contributing guidelines: there isn't a contrib branch on this repo so I assumed v11/develop was the one to branch from 🤞

@D-Inventor
Copy link
Member

I love it, looking good so far!

v11/develop is a good branch to work from. When this pull request is merged, I can port it to other versions as well.

@D-Inventor D-Inventor self-requested a review September 18, 2023 08:55
@LottePitcher
Copy link
Author

Thanks @D-Inventor for such a prompt review! I shall keep going!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants