start port over to the shared kzg lib (#37) (#38)

* start port over to the shared kzg lib

* have CL compute the aggregated proof for the block, per updated spec

beacon-chain/core/transition/transition_no_verify_sig.go

@@ -5,14 +5,14 @@ import (
  "context"
  "fmt"
 
+ "github.com/ethereum/go-ethereum/crypto/kzg"
  "github.com/pkg/errors"
  "github.com/prysmaticlabs/prysm/v3/beacon-chain/core/altair"
  b "github.com/prysmaticlabs/prysm/v3/beacon-chain/core/blocks"
  "github.com/prysmaticlabs/prysm/v3/beacon-chain/core/transition/interop"
  v "github.com/prysmaticlabs/prysm/v3/beacon-chain/core/validators"
  "github.com/prysmaticlabs/prysm/v3/beacon-chain/state"
  "github.com/prysmaticlabs/prysm/v3/consensus-types/blocks"
- "github.com/prysmaticlabs/prysm/v3/consensus-types/forks/eip4844"
  "github.com/prysmaticlabs/prysm/v3/consensus-types/interfaces"
  "github.com/prysmaticlabs/prysm/v3/crypto/bls"
  "github.com/prysmaticlabs/prysm/v3/encoding/bytesutil"
@@ -275,16 +275,16 @@ func ProcessBlobKzgs(ctx context.Context, state state.BeaconState, body interfac
  if err != nil {
  return nil, errors.Wrap(err, "could not get blob kzgs from block")
  }
- blobKzgsInput := make([][48]byte, len(blobKzgs))
+ blobKzgsInput := make(kzg.KZGCommitmentSequenceImpl, len(blobKzgs))
  for i := range blobKzgs {
- blobKzgsInput[i] = bytesutil.ToBytes48(blobKzgs[i])
+ blobKzgsInput[i] = kzg.KZGCommitment(bytesutil.ToBytes48(blobKzgs[i]))
  }
 
  txs, err := payload.Transactions()
  if err != nil {
  return nil, errors.Wrap(err, "could not get transactions from payload")
  }
- if err := eip4844.VerifyKzgsAgainstTxs(txs, blobKzgsInput); err != nil {
+ if err := kzg.VerifyKZGCommitmentsAgainstTransactions(txs, blobKzgsInput); err != nil {
  return nil, errors.Wrap(err, "could not verify kzgs against txs")
  }
  return state, nil

beacon-chain/sync/validate_beacon_blocks.go

@@ -5,10 +5,10 @@ import (
  "fmt"
  "time"
 
+ "github.com/ethereum/go-ethereum/crypto/kzg"
  "github.com/libp2p/go-libp2p-core/peer"
  pubsub "github.com/libp2p/go-libp2p-pubsub"
  "github.com/pkg/errors"
- "github.com/protolambda/go-kzg/bls"
  "github.com/prysmaticlabs/prysm/v3/beacon-chain/core/blocks"
  "github.com/prysmaticlabs/prysm/v3/beacon-chain/core/feed"
  blockfeed "github.com/prysmaticlabs/prysm/v3/beacon-chain/core/feed/block"
@@ -18,7 +18,6 @@ import (
  "github.com/prysmaticlabs/prysm/v3/config/features"
  "github.com/prysmaticlabs/prysm/v3/config/params"
  consensusblocks "github.com/prysmaticlabs/prysm/v3/consensus-types/blocks"
- "github.com/prysmaticlabs/prysm/v3/consensus-types/forks/eip4844"
  "github.com/prysmaticlabs/prysm/v3/consensus-types/interfaces"
  types "github.com/prysmaticlabs/prysm/v3/consensus-types/primitives"
  "github.com/prysmaticlabs/prysm/v3/encoding/bytesutil"
@@ -294,21 +293,15 @@ func (s *Service) validateEIP4844BeaconBlock(ctx context.Context, parentState st
  if err != nil {
  return err
  }
- blobKzgsInput := make([][48]byte, len(blobKzgs))
+ blobKzgsInput := make(kzg.KZGCommitmentSequenceImpl, len(blobKzgs))
  for i := range blobKzgs {
- if len(blobKzgs[i]) != 48 {
- return errors.New("invalid blob kzg length")
- }
- if _, err := bls.FromCompressedG1(blobKzgs[i]); err != nil {
- return errors.Wrap(err, "invalid blob kzg encoding")
- }
- blobKzgsInput[i] = bytesutil.ToBytes48(blobKzgs[i])
+ blobKzgsInput[i] = kzg.KZGCommitment(bytesutil.ToBytes48(blobKzgs[i]))
  }
  txs, err := payload.Transactions()
  if err != nil {
  return err
  }
- return eip4844.VerifyKzgsAgainstTxs(txs, blobKzgsInput)
+ return kzg.VerifyKZGCommitmentsAgainstTransactions(txs, blobKzgsInput)
 }
 
 // validateBellatrixBeaconBlock validates the block for the Bellatrix fork.

go.mod

@@ -269,4 +269,4 @@ replace github.com/json-iterator/go => github.com/prestonvanloon/go v1.1.7-0.201
 replace github.com/grpc-ecosystem/grpc-gateway/v2 => github.com/prysmaticlabs/grpc-gateway/v2 v2.3.1-0.20220721162526-0d1c40b5f064
 
 // For eip-4844 types
-replace github.com/ethereum/go-ethereum => github.com/mdehoog/go-ethereum v1.10.19-0.20221114011613-42a69e6e01ae
+replace github.com/ethereum/go-ethereum => github.com/mdehoog/go-ethereum v1.10.19-0.20221116191641-aa63d265361b

go.sum

@@ -865,8 +865,8 @@ github.com/mattn/go-sqlite3 v1.11.0/go.mod h1:FPy6KqzDD04eiIsT53CuJW3U88zkxoIYsO
 github.com/mattn/go-tty v0.0.0-20180907095812-13ff1204f104/go.mod h1:XPvLUNfbS4fJH25nqRHfWLMa1ONC8Amw+mIA639KxkE=
 github.com/matttproud/golang_protobuf_extensions v1.0.1 h1:4hp9jkHxhMHkqkrB3Ix0jegS5sx/RkqARlsWZ6pIwiU=
 github.com/matttproud/golang_protobuf_extensions v1.0.1/go.mod h1:D8He9yQNgCq6Z5Ld7szi9bcBfOoFv/3dc6xSMkL2PC0=
-github.com/mdehoog/go-ethereum v1.10.19-0.20221114011613-42a69e6e01ae h1:2wXfDkt06PPDhG4Lxkse69fDegYljvz9fSZExd5V41c=
-github.com/mdehoog/go-ethereum v1.10.19-0.20221114011613-42a69e6e01ae/go.mod h1:g+vX1+faxlr/KM1C0wybtfdcH5aPghqJAfpLGAn+Kbk=
+github.com/mdehoog/go-ethereum v1.10.19-0.20221116191641-aa63d265361b h1:1+lop5PhC3ilW7lthuSFf1DWxSb5X6O+kd7I6nvbi3c=
+github.com/mdehoog/go-ethereum v1.10.19-0.20221116191641-aa63d265361b/go.mod h1:g+vX1+faxlr/KM1C0wybtfdcH5aPghqJAfpLGAn+Kbk=
 github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b h1:j7+1HpAFS1zy5+Q4qx1fWh90gTKwiN4QCGoY9TWyyO4=
 github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b/go.mod h1:01TrycV0kFyexm33Z7vhZRXopbI8J3TDReVlkTgMUxE=
 github.com/microcosm-cc/bluemonday v1.0.1/go.mod h1:hsXNsILzKxV+sX77C5b8FSuKF00vh2OMYv+xgHpAMF4=