Skip to content

Commit

Permalink
string comparing changed
Browse files Browse the repository at this point in the history
We can't compare strings with '<=' (The 'else' statement run in case  strings are equals).
So I will separately check first '==' after '<'
  • Loading branch information
Tamir91 committed Sep 27, 2023
1 parent abf62d3 commit de4aa64
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/CMake-minimal-version.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: "Check minimal CMake version"
run: |
if [ "${{steps.cmake_version.outputs.current_cmake_version}}" <= "${EXPECTED_CMAKE_VERSION}" ]
if [ "${{steps.cmake_version.outputs.current_cmake_version}}" == "${EXPECTED_CMAKE_VERSION}" || "${{steps.cmake_version.outputs.current_cmake_version}}" \< "${EXPECTED_CMAKE_VERSION}" ]
then
echo "The test PASSED, CMake ${{steps.cmake_version.outputs.current_cmake_version}} found same as expecting ${EXPECTED_CMAKE_VERSION}"
exit 0
Expand Down

0 comments on commit de4aa64

Please sign in to comment.