Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing GHA Minimal CMake version check #12266

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fixing GHA Minimal CMake version check #12266

merged 1 commit into from
Oct 9, 2023

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Oct 8, 2023 •
edited
Loading

Fixing PR: #12118
Tracked on [LRS-844]

@Nir-Az Nir-Az force-pushed the fix_gha_cmake branch 9 times, most recently from 191ccbc to 7d39694 Compare October 9, 2023 05:58
@Nir-Az Nir-Az changed the title test PR Fixing GHA Minimal CMake version check Oct 9, 2023
@Nir-Az Nir-Az requested a review from maloel October 9, 2023 06:12
maloel
maloel approved these changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@maloel maloel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to see what changes you made. Next time I recommend moving in one commit and then making changes in another.

I don't quite understand the need for venv, but seems OK.

@Nir-Az
Copy link
Collaborator Author

Nir-Az commented Oct 9, 2023

Hard to see what changes you made. Next time I recommend moving in one commit and then making changes in another.

I don't quite understand the need for venv, but seems OK.

Yes I agree, next time.

  • venv is part of the tool setup instructions to keep a clean python environment
  • The changes are cosmetics, naming and such.

@Nir-Az Nir-Az merged commit 3f17622 into IntelRealSense:development Oct 9, 2023
17 checks passed
@Nir-Az Nir-Az mentioned this pull request Oct 9, 2023
Closed
@Nir-Az Nir-Az deleted the fix_gha_cmake branch September 30, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maloel maloel maloel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nir-Az @maloel