-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage of assert
s
#362
Labels
Comments
Merged
This is kind of how asserts are supposed to work, but IMO it's a good idea to just enable them ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are a few places in KES implementation where
Control.Exception.assert
is being used. This has no affect sinceassert
s will never get triggered, because they are removed by the compiler, unless compiled with either-O0
or-fno-ignore-asserts
, which is never the case in this repo.So, we need figure out whats the purpose of those asserts and either remove them in favor of some other mode of failure or make them count with a cabal flag or something. A good example on how latter can be achieved is in the consensus repo.
The text was updated successfully, but these errors were encountered: