Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flawed accept/connect interaction in Snocket. #3449

Closed
bolt12 opened this issue Oct 22, 2021 · 0 comments · Fixed by #3360
Closed

Flawed accept/connect interaction in Snocket. #3449

bolt12 opened this issue Oct 22, 2021 · 0 comments · Fixed by #3360
Labels
io-sim-discovered Issue discovered by IOSim net-sim Issues / PRs related to network simulator testing

Comments

@bolt12
Copy link
Contributor

bolt12 commented Oct 22, 2021

I found one more bug in the accept/connect interaction, and I think it is due to the use of normaliseId . Basically, if I connect to someone and someone connects to me, before the connect returns (and before the remote accept returns as well) the local accept can return first masking itself as the remote one because we have no way to distinguish directions. This is a good test for the Snocket suite!
@bolt12 bolt12 linked a pull request Oct 22, 2021 that will close this issue
Validate connection manager/inbound governor transition order #3360
Merged
@bolt12 bolt12 added net-sim Issues / PRs related to network simulator networking labels Oct 22, 2021
@bolt12 bolt12 mentioned this issue Oct 22, 2021
Merged
@bolt12 bolt12 closed this as completed Nov 3, 2021
@bolt12 bolt12 added the io-sim-discovered Issue discovered by IOSim label Nov 30, 2021
@coot coot changed the title Flawd accept/connect interaction in Snocket. Flawed accept/connect interaction in Snocket. Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
io-sim-discovered Issue discovered by IOSim net-sim Issues / PRs related to network simulator testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate connection manager/inbound governor transition order IntersectMBO/ouroboros-network
1 participant
@bolt12