Relax the semver requirement for protobuf #193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow downstream consumers to choose their version of protobuf without causing build issues.
I realized this while looking at https:/tikv/rust-prometheus/blob/master/Cargo.toml
I tested this by
git reset
ing logdriver to an old revision that used protobuf 2.14. It compiled file. It also compiled fine with a dependency of 2.17.There might still be problems in upgrading to newer version because we have custom
build.rs
logic for the proto generation, but at least cargo will be able to successfully select a version.If we merge this, I think we can close #188