Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#22] Unmanaged Decryption #32

Merged
merged 9 commits into from
Aug 20, 2019
Merged

[#22] Unmanaged Decryption #32

merged 9 commits into from
Aug 20, 2019

Conversation

clintfred
Copy link
Contributor

@clintfred clintfred commented Aug 15, 2019 •
edited
Loading

see #22

Changelog

DocumentAdvancedOps::document_decrypt_unmanaged function added for advanced use cases. This decrypt operation is the inverse of DocumentAdvancedOps::document_encrypt_unmanaged

clintfred
clintfred commented Aug 16, 2019
View reviewed changes
Copy link
Contributor Author

@clintfred clintfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review of PR

src/internal/document_api/mod.rs Show resolved Hide resolved
src/internal/document_api/mod.rs Outdated Show resolved Hide resolved
src/internal/document_api/mod.rs Outdated Show resolved Hide resolved
tests/document_ops.rs Outdated Show resolved Hide resolved
src/internal/document_api/mod.rs Show resolved Hide resolved
BobWall23
BobWall23 requested changes Aug 16, 2019
View reviewed changes
src/internal/document_api/mod.rs Show resolved Hide resolved
src/internal/document_api/mod.rs Show resolved Hide resolved
src/internal/document_api/mod.rs Outdated Show resolved Hide resolved
src/internal/document_api/mod.rs Show resolved Hide resolved
src/internal/document_api/mod.rs Outdated Show resolved Hide resolved
coltfred
coltfred requested changes Aug 19, 2019
View reviewed changes
Copy link
Member

@coltfred coltfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proto encoding failing feels weird to me and a reordering issue for consistency.

src/document/advanced.rs Show resolved Hide resolved
src/internal/document_api/mod.rs Show resolved Hide resolved
@clintfred clintfred merged commit cf64122 into master Aug 20, 2019
@clintfred clintfred deleted the 22-decrypt-unmanaged branch August 20, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobWall23 BobWall23 BobWall23 requested changes

@giarc3 giarc3 giarc3 left review comments

@coltfred coltfred coltfred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clintfred @coltfred @BobWall23 @giarc3