Fix PHP warnings when indexing in solr #114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue: (link)
Release pull requests, etc.)
What does this Pull Request do?
Continues iterating over the loop if an EDTF value isn't defined
Was getting these warnings in my watchdog when indexing nodes in solr:
What's new?
Just declaring some variables that cause warning if the assumptions in the code aren't met.
How should this be tested?
I tested by just making the code changes and seeing the watchdog messages go away.
Additional Notes:
Any additional information that you think would be helpful when reviewing this
PR.
Interested parties
@Islandora/committers