Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Keys/ID #36

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from
Open

Conversation

DonRichards
Copy link
Member

GitHub Issue: N/A

What does this Pull Request do?

Adds ID to the CSV and changes the keys to point to ID instead of file

What's new?

  • CSV column ID
  • migration_lookup source to ID

How should this be tested?

Run the migration and verify it migrated.

Additional Notes:

N/A

Interested parties

@Islandora/8-x-committers

@rosiel
Copy link
Member

rosiel commented Aug 5, 2020

comments from Tech Call:

  • maybe next step would be to rename 'file' column to 'file_name' or 'file_path'?
  • and maybe add a line in the CSV that is a collection (no file)? might be cleaner to make a separate migration for collections.
  • also don't forget to change the documentation!

Update migrate_plus.migration.example_migration_media.yml
Update migrate_plus.migration.example_migration_node.yml
Update migrate_plus.migration.example_migration_file.yml
Update migration.csv
Change file to filename & resolves naming conflict
Create collections.csv
Create migrate_plus.migration.collections_file.yml
Create migrate_plus.migration.collections_media.yml
Rename migrate_plus.migration.collections_file.yml to migrate_plus.migration.example_collections_file.yml
Update and rename migrate_plus.migration.collections_media.yml to migrate_plus.migration.example_collections_media.yml
Create migrate_plus.migration.example_collections_node.yml
Create migrate_plus.migration.collections_subjects.yml
Create collection_subjects.csv
Update and rename migrate_plus.migration.collections_subjects.yml to migrate_plus.migration.example_collections_subjects.yml
Update collections.csv
Update migrate_plus.migration.example_collections_node.yml
Update migrate_plus.migration.example_collections_file.yml
Update migrate_plus.migration.example_collections_file.yml
Update migrate_plus.migration.example_collections_node.yml
Update migrate_plus.migration.example_collections_media.yml
Update migrate_plus.migration.example_collections_file.yml
Update migrate_plus.migration.example_collections_node.yml
Includes requested features to show
@bseeger bseeger changed the base branch from dev to 2.x October 5, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants