Skip to content

Commit

Permalink
Remove an incorrect impl of ReadOnlySystemParam for NonSendMut (b…
Browse files Browse the repository at this point in the history
…evyengine#7243)

# Objective

The trait `ReadOnlySystemParam` is implemented for `NonSendMut`, when it should not be. This mistake was made in bevyengine#6919.

## Solution

Remove the incorrect impl.
  • Loading branch information
JoJoJet authored and ItsDoot committed Feb 1, 2023
1 parent 9b14b41 commit ecc4006
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions crates/bevy_ecs/src/system/system_param.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1012,9 +1012,6 @@ unsafe impl<T: 'static> SystemParam for Option<NonSend<'_, T>> {
}
}

// SAFETY: Only reads a single non-send resource
unsafe impl<'a, T: 'static> ReadOnlySystemParam for NonSendMut<'a, T> {}

// SAFETY: NonSendMut ComponentId and ArchetypeComponentId access is applied to SystemMeta. If this
// NonSendMut conflicts with any prior access, a panic will occur.
unsafe impl<'a, T: 'static> SystemParam for NonSendMut<'a, T> {
Expand Down

0 comments on commit ecc4006

Please sign in to comment.