-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minify breaks google font urls #113
Comments
Look, this seems to be the issue, just found it: however, i am not sure how this important fix is propagated to the current gulp-minify package, I updated it but the error still occurs, too tired now to dig into the npm dependency thing... |
I just deleted all node modules and installed again, now everything is ok. I still do not understand the node packaging thing, seems somehow strange to me that updates are not doing what I expect them to do. I will spend some day in the far future with studying the depths of node packages and the unexpected problems that occur with updates, a very interesting yak shaving playground. |
this may be a problem not created here, but I could not find a quick solution in the issue trackers for clean-css or the gulp-minify wrapper, so I am putting it here as a starting point:
the minified style.min.css has broken urls to google fonts - this does not happen in the not minified css, so the minify process seems to be the problem. I was wondering about 404 errors in the browser dev console, and in fact the google font url in the minified css has a ../../ prefixed:
url(../../fonts.gstatic.com/s/opensans ...
I changed
relative_assets = true
torelative_assets = false
in config.rb, but this has no effect on that breakage. ATM I have no clue where that relative directory prefix is coming from, but maybe if you read this you will immediately know what's wrong.Thanks for your attention again!
The text was updated successfully, but these errors were encountered: