-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Control Panel #125
Add Control Panel #125
Conversation
Thank you for your effort.
|
The Feed Module (if you mean "JoomGallery News" ) is working well without error message. Only Link to Joom::Gallery friends - Startseite is not correct. Possible Improvements CP:
|
This Link |
I would expect when a link text describes "to home page" to come there and not open a feed file. Otherwise the text is wrong... |
Thanks you for your advice.
I have tried to display the installed extensions. The extensions that have 'joomgallery' in their name or are installed in the 'joomgallery' folder are displayed.
The desired button back to control panel has now been added.
I can't imagine what this should look like and where it should be displayed.
The link is generated automatically by Joomla. This was also the case in Joomla 3.x. Unfortunately, I see no possibility to change this, only to switch the title off.
Confirmed, but it is strange.
I am still looking for a solution... |
Images top lists are now added. Note: Before anything can be displayed, you must enter a few values in the database table. |
Why do we now have the "<- Control Panel" button everywhere in "Images" to "Maintenance"? |
This is exactly what rowi68 and I asked for. I think this thing is mandatory. You should not rely on the browser BACK function here. people will look up at the options how do I get back now.... |
In my opinion would be "statistic" and "information" only a side information and should placed at bottom of page. |
Add css class to move cogs icon to right. |
What exactly should be at the top? |
No, I think this logo is familiar for now and shouldn't be changed at the moment unless it's refreshed with new technology. Users shouldn't be confused by a new logo as well as what's going on here |
The maximum number of images is currently defined in line 60 of the file administrator/components/com_joomgallery/src/View/Control/HtmlView.php: |
Globale conficuration - generell setting - (6.point) -> "Display Images in Control Panel", |
Thanks for the changes. |
A horizontal line added.
I have added an additional check so that only between 1 and 100 images can displayed. |
Thank you for changes. Looks better with horizontal line now... I think that this text :
under the logo would be not very important for backend-users, becauce JG4 is already installed and webmaster knows that usually. Would it not be better to place the logo above donation text and display one box only? |
@reni68 @rowi68 : |
Yes, with the feed date deactivated, this message does not appear. |
I cannot reproduce the error. No matter if i activate or deactivate the feed date --> everything is fine. |
I have installed this branch in another Joomla installation (basic data are identical) and can no longer reproduce the error. Not bad either ;-) |
too big for my liking :/ |
Yes, I also think it's too big |
Small changes: |
@rowi68 Thank you for your suggestion. |
I think its time now to merge this PR into main. |
@Elfangor93 What do you mean? |
Everything looks good except for the installation script file. You are reverting here some stuff I optimized lately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have updated my branch. hope it is correct now.
This PR adds a 'Control Panel' to the admin area of the JoomGallery.
In this control panel important information for the user should be displayed.
This is only a draft for now.
What information should be displayed?
How can the user experience be improved?
Any other suggestions?
Please note:
During installation an administrator module is created to display a feed from the JoomGallery website.
Unfortunately there is a bug in Joomla that currently leads to an endless loop.
A bugfix was already submitted a long time ago but unfortunately not merged.
In order to test the control panel with the feed module, you have to make the following change in the file /libraries/vendor/joomla/filter/src/InputFilter.php at line 728:
$nextAfter = $nextBefore + $closeQuoteChars;
Presumably it would make sense to submit a PR for the framework again to draw attention to the problem?