-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bug: npx create-typescript-app failed to migrate tests #1355
Comments
...huh, interesting! Just to confirm, I think I can spot at least the following two issues:
For 🍏 the test workflow, that seems like a straightforward bug and what I think you're pointing at. Accepting PRs! For 🍌 migrating tests from Jest to Vitest, I'm not positive that that's actually what you're asking about. But it's something I've been back-of-mind thinking about... unfortunately there's no good migrator that I know of, and making one could be super complex. I think it'd be better to leave that as a followup issue for logging a message suggesting folks use one. Was there anything else missing @danvk? |
If migrating from Jest → Vitest is hard and out of scope, that's fine. My suggestion then would be to make the I'd also suggest removing this text from the Migration docs:
So stepping back, maybe my request would be for the docs to explain what I'm expected to do with my existing Jest tests before or after I run the migration script. |
Filed #1375 for the docs callout. 👍
Aha, I think I see the issue!
Specifically: That's a bug. It should have at least asked you what Btw, I set up a standalone repro in https:/JoshuaKGoldberg/repros/tree/create-typescript-app-jest-to-vitest-migration. In case it's useful. Is there anything else we should change? I'm splitting out issues to keep the comment histories cleaner, and adding Co-authored-by. |
Bug Report Checklist
main
branch of the repository.Expected
I expected
npx create-typescript-app
to migrate my tests from Jest to vitest as described in https:/JoshuaKGoldberg/create-typescript-app/blob/main/docs/Migration.mdActual
The tests were not migrated.
Based on the "Required" but un-run statuses in this PR branch, I think I may be in some kind of bad state?
danvk/literate-ts#246
It doesn't look like I have any workflow that would run my repo's tests, for example.
Additional Info
There were no errors relating to tests when I ran
npx create-typescript-app
. The logs are below.The text was updated successfully, but these errors were encountered: